Fix functional test race condition in nova template configuration#1558
Merged
openshift-merge-bot[bot] merged 1 commit intoAug 11, 2025
Merged
Conversation
The "should have configured nova from the service template" test was failing intermittently due to a stale object update pattern. The test was retrieving the OpenStackControlPlane object outside the Eventually block, then attempting to update it inside the block. This could fail with update conflicts if the controller modified the object between retrieval and update. Move GetOpenStackControlPlane() inside the Eventually block to ensure a fresh object is retrieved on each retry attempt, matching the pattern used by other successful tests in the file. Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
Author
|
functional tests sometimes fail with |
stuggi
requested review from
abays and
dprince
and removed request for
lewisdenny and
slagle
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit d0e8ae9
into
openstack-k8s-operators:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "should have configured nova from the service template" test was failing intermittently due to a stale object update pattern. The test was retrieving the OpenStackControlPlane object outside the Eventually block, then attempting to update it inside the block. This could fail with update conflicts if the controller modified the object between retrieval and update.
Move GetOpenStackControlPlane() inside the Eventually block to ensure a fresh object is retrieved on each retry attempt, matching the pattern used by other successful tests in the file.